Add tagging action #298
Add tagging action #298
Conversation
nb1701
force-pushed
the
nb1701/add_tagging_action
branch
3 times, most recently
from
f37b647
to
9b83e41
Compare
|
I tested this with some |
.github/workflows/tag.yaml
Outdated
| run: | | ||
| git config user.email "github-actions[bot]@users.noreply.github.com" | ||
| git config user.name "github-actions[bot]" | ||
| git tag -a ${{ github.event.inputs.release_number }} -m "Release ${{ github.event.inputs.release_number }}" |
There was a problem hiding this comment.
| git tag -a ${{ github.event.inputs.release_number }} -m "Release ${{ github.event.inputs.release_number }}" | |
| git tag ${{ github.event.inputs.release_number }} --message="Release ${{ github.event.inputs.release_number }}" |
I had to look up the -a since I hadn't used it. I'd remove it unless you found a reason it needs to be explicitly set. The docs say:
If -m or -F is given and -a, -s, and -u are absent, -a is implied.
There was a problem hiding this comment.
The -a is the actual tag, and the -m is a message for the tag. I have it slightly different here, but I guess it doesn't need to be so.
There was a problem hiding this comment.
It would seem git tag -m doesn't really work on its own, despite what it says here.
There was a problem hiding this comment.
Oh, it's git tag <tag> -m <whatever>. I think I'll just remove the -m and -a entirely.
There was a problem hiding this comment.
Nope, we still want the -m or else it just fills it in with the commit message of the commit it's tagged on.
Is that a thing we can do? Might still be nice to have the option to run it manually in case things go sideways, but I don't know. It's pretty easy to delete a bad tag if we need to. |
nb1701
force-pushed
the
nb1701/add_tagging_action
branch
2 times, most recently
from
7548556
to
1d1838d
Compare
.github/workflows/tag.yaml
Outdated
| run: | | ||
| git config user.email "github-actions[bot]@users.noreply.github.com" | ||
| git config user.name "github-actions[bot]" | ||
| git tag ${{ github.event.inputs.version }} -m "${{ github.event.inputs.version }}" |
There was a problem hiding this comment.
| git tag ${{ github.event.inputs.version }} -m "${{ github.event.inputs.version }}" | |
| git tag ${{ github.event.inputs.version }} --message="${{ github.event.inputs.version }}" |
Using the full arg name make it easier to understand at a glance.
I thought there was a trigger type that let use trigger it, but not in the ui. I might be remembering wrong. |
|
Ah yeah, there's https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#workflow_call, but I'm not sure if that works cross-repo. https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#repository_dispatch might also work. I'll take a look at those when I work on the civiform release action trigger. |
nb1701
force-pushed
the
nb1701/add_tagging_action
branch
from
1d1838d
to
eadf265
Compare
Adds an action to tag the repo. Partially addresses civiform/civiform#4763